Freeze the strings we're not later modifying

There's a few plugins that this couldn't be enabled on due to how we build strings, but for the most part this is an easy one to turn on and it shaves 1k from the runtime memory! Signed-off-by: Tim Smith <[email protected]>
skillstream · Oct 30, 2020 · d1da1e4 · d1da1e4
1 parent e5ecdfd
commit d1da1e4
Show file tree

Hide file tree

Showing 142 changed files with 143 additions and 1 deletion.
diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 source "https://rubygems.org"
 
 gemspec
@@ -22,6 +23,6 @@ end
 group :debug do
   gem "pry"
   gem "pry-byebug"
-  gem "pry-stack_explorer", "~> 0.4.0" # pin until we drop ruby < 2.6
+  gem "pry-stack_explorer"
   gem "rb-readline"
 end
diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "bundler/gem_tasks"
 
 begin

diff --git a/bin/ohai b/bin/ohai
@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) 2008-2016 Chef Software, Inc.

diff --git a/lib/ohai.rb b/lib/ohai.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/application.rb b/lib/ohai/application.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Mathieu Sauve-Frankel <[email protected]>
 # Copyright:: Copyright (c) 2009 Mathieu Sauve-Frankel.

diff --git a/lib/ohai/common/dmi.rb b/lib/ohai/common/dmi.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Kurt Yoder ([email protected])
 # Copyright:: Copyright (c) 2010 Kurt Yoder

diff --git a/lib/ohai/config.rb b/lib/ohai/config.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Author:: Claire McQuin (<[email protected]>)

diff --git a/lib/ohai/dsl.rb b/lib/ohai/dsl.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Serdar Sutay (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/dsl/plugin.rb b/lib/ohai/dsl/plugin.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Author:: Claire McQuin (<[email protected]>)

diff --git a/lib/ohai/dsl/plugin/versionvii.rb b/lib/ohai/dsl/plugin/versionvii.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Serdar Sutay (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/exception.rb b/lib/ohai/exception.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/hints.rb b/lib/ohai/hints.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Serdar Sutay (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/log.rb b/lib/ohai/log.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/mash.rb b/lib/ohai/mash.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/mixin/azure_metadata.rb b/lib/ohai/mixin/azure_metadata.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Tim Smith (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/mixin/chef_utils_wiring.rb b/lib/ohai/mixin/chef_utils_wiring.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/mixin/command.rb b/lib/ohai/mixin/command.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 $stderr.puts "WARN: Ohai::Mixin::Command is deprecated, please use Ohai::Mixin::ShellOut or remove if the reference is unnecessary"
 require_relative "shell_out"
 Ohai::Mixin::Command = Ohai::Mixin::ShellOut unless defined?(Ohai::Mixin::Command)
diff --git a/lib/ohai/mixin/constant_helper.rb b/lib/ohai/mixin/constant_helper.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Serdar Sutay (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/mixin/dmi_decode.rb b/lib/ohai/mixin/dmi_decode.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Tim Smith <[email protected]>
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/mixin/do_metadata.rb b/lib/ohai/mixin/do_metadata.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 # Author:: Dylan Page (<[email protected]>)
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/mixin/ec2_metadata.rb b/lib/ohai/mixin/ec2_metadata.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Tim Dysinger (<[email protected]>)
 # Author:: Benjamin Black (<[email protected]>)

diff --git a/lib/ohai/mixin/gce_metadata.rb b/lib/ohai/mixin/gce_metadata.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Ranjib Dey (<[email protected]>)
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/mixin/http_helper.rb b/lib/ohai/mixin/http_helper.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/mixin/network_helper.rb b/lib/ohai/mixin/network_helper.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Serdar Sutay (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/mixin/os.rb b/lib/ohai/mixin/os.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/mixin/scaleway_metadata.rb b/lib/ohai/mixin/scaleway_metadata.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Jonathan Amiez (<[email protected]>)
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/mixin/seconds_to_human.rb b/lib/ohai/mixin/seconds_to_human.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/mixin/shell_out.rb b/lib/ohai/mixin/shell_out.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Author:: Tim Smith (<[email protected]>)

diff --git a/lib/ohai/mixin/softlayer_metadata.rb b/lib/ohai/mixin/softlayer_metadata.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Alexey Karpik <[email protected]>
 # Author:: Peter Schroeter <[email protected]>

diff --git a/lib/ohai/mixin/string.rb b/lib/ohai/mixin/string.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: James Gartrell (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/mixin/train_helpers.rb b/lib/ohai/mixin/train_helpers.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/mixin/which.rb b/lib/ohai/mixin/which.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/plugin_config.rb b/lib/ohai/plugin_config.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/plugins/aix/kernel.rb b/lib/ohai/plugins/aix/kernel.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Joshua Timberman <[email protected]>
 # Author:: Isa Farnik (<[email protected]>)

diff --git a/lib/ohai/plugins/aix/memory.rb b/lib/ohai/plugins/aix/memory.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Joshua Timberman <[email protected]>
 # Author:: Isa Farnik (<[email protected]>)

diff --git a/lib/ohai/plugins/aix/network.rb b/lib/ohai/plugins/aix/network.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Kaustubh Deorukhkar (<[email protected]>)
 # Author:: Prabhu Das (<[email protected]>)

diff --git a/lib/ohai/plugins/aix/platform.rb b/lib/ohai/plugins/aix/platform.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Joshua Timberman <[email protected]>
 # Author:: Isa Farnik (<[email protected]>)

diff --git a/lib/ohai/plugins/aix/uptime.rb b/lib/ohai/plugins/aix/uptime.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Kurt Yoder (<[email protected]>)
 # Author:: Isa Farnik (<[email protected]>)

diff --git a/lib/ohai/plugins/azure.rb b/lib/ohai/plugins/azure.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0
 #

diff --git a/lib/ohai/plugins/bsd/virtualization.rb b/lib/ohai/plugins/bsd/virtualization.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Bryan McLellan ([email protected])
 # Copyright:: Copyright (c) 2009 Bryan McLellan

diff --git a/lib/ohai/plugins/c.rb b/lib/ohai/plugins/c.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Doug MacEachern <[email protected]>
 # Copyright:: Copyright (c) 2010 VMware, Inc.

diff --git a/lib/ohai/plugins/chef.rb b/lib/ohai/plugins/chef.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Tollef Fog Heen <[email protected]>
 # Copyright:: Copyright (c) 2010 Tollef Fog Heen

diff --git a/lib/ohai/plugins/cloud.rb b/lib/ohai/plugins/cloud.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Cary Penniman (<[email protected]>)
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/plugins/command.rb b/lib/ohai/plugins/command.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/cpu.rb b/lib/ohai/plugins/cpu.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Author:: Bryan McLellan ([email protected])

diff --git a/lib/ohai/plugins/darwin/hardware.rb b/lib/ohai/plugins/darwin/hardware.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Nate Walck (<[email protected]>)
 # Copyright:: Copyright (c) 2016-present Facebook, Inc.

diff --git a/lib/ohai/plugins/darwin/memory.rb b/lib/ohai/plugins/darwin/memory.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Patrick Collins (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/darwin/network.rb b/lib/ohai/plugins/darwin/network.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Benjamin Black (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/darwin/platform.rb b/lib/ohai/plugins/darwin/platform.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/darwin/virtualization.rb b/lib/ohai/plugins/darwin/virtualization.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Pavel Yudin (<[email protected]>)
 # Author:: Tim Smith (<[email protected]>)

diff --git a/lib/ohai/plugins/digital_ocean.rb b/lib/ohai/plugins/digital_ocean.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Dylan Page (<[email protected]>)
 # Author:: Stafford Brunk (<[email protected]>)

diff --git a/lib/ohai/plugins/dmi.rb b/lib/ohai/plugins/dmi.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Kurt Yoder ([email protected])
 # Copyright:: Copyright (c) 2010 Kurt Yoder

diff --git a/lib/ohai/plugins/docker.rb b/lib/ohai/plugins/docker.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/plugins/dragonflybsd/memory.rb b/lib/ohai/plugins/dragonflybsd/memory.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Bryan McLellan ([email protected])
 # Copyright:: Copyright (c) 2009 Bryan McLellan

diff --git a/lib/ohai/plugins/dragonflybsd/network.rb b/lib/ohai/plugins/dragonflybsd/network.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Bryan McLellan ([email protected])
 # Copyright:: Copyright (c) 2009 Bryan McLellan

diff --git a/lib/ohai/plugins/dragonflybsd/platform.rb b/lib/ohai/plugins/dragonflybsd/platform.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Bryan McLellan ([email protected])
 # Copyright:: Copyright (c) 2009 Bryan McLellan

diff --git a/lib/ohai/plugins/ec2.rb b/lib/ohai/plugins/ec2.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Tim Dysinger (<[email protected]>)
 # Author:: Benjamin Black (<[email protected]>)

diff --git a/lib/ohai/plugins/erlang.rb b/lib/ohai/plugins/erlang.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Joe Williams (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/eucalyptus.rb b/lib/ohai/plugins/eucalyptus.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Tim Dysinger (<[email protected]>)
 # Author:: Benjamin Black (<[email protected]>)

diff --git a/lib/ohai/plugins/fips.rb b/lib/ohai/plugins/fips.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Matt Wrock (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/freebsd/memory.rb b/lib/ohai/plugins/freebsd/memory.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Bryan McLellan ([email protected])
 # Copyright:: Copyright (c) 2009 Bryan McLellan

diff --git a/lib/ohai/plugins/freebsd/network.rb b/lib/ohai/plugins/freebsd/network.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Bryan McLellan ([email protected])
 # Copyright:: Copyright (c) 2009 Bryan McLellan

diff --git a/lib/ohai/plugins/freebsd/platform.rb b/lib/ohai/plugins/freebsd/platform.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Bryan McLellan ([email protected])
 # Copyright:: Copyright (c) 2009 Bryan McLellan

diff --git a/lib/ohai/plugins/gce.rb b/lib/ohai/plugins/gce.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Ranjib Dey (<[email protected]>)
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/plugins/haskell.rb b/lib/ohai/plugins/haskell.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Author:: Chris Dituri (<[email protected]>)
 # Copyright:: Copyright (c) 2016 Chris Dituri
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/plugins/hostname.rb b/lib/ohai/plugins/hostname.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Author:: Benjamin Black (<[email protected]>)

diff --git a/lib/ohai/plugins/init_package.rb b/lib/ohai/plugins/init_package.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Caleb Tennis (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/java.rb b/lib/ohai/plugins/java.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Benjamin Black (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/joyent.rb b/lib/ohai/plugins/joyent.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author: [email protected]
 # Copyright (C) 2014 HiganWorks LLC

diff --git a/lib/ohai/plugins/kernel.rb b/lib/ohai/plugins/kernel.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Author:: Benjamin Black (<[email protected]>)

diff --git a/lib/ohai/plugins/keys.rb b/lib/ohai/plugins/keys.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Cookbook Name:: apache2
 # Recipe:: default

diff --git a/lib/ohai/plugins/languages.rb b/lib/ohai/plugins/languages.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/libvirt.rb b/lib/ohai/plugins/libvirt.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Benjamin Black (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/linode.rb b/lib/ohai/plugins/linode.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Aaron Kalin (<[email protected]>)
 # License:: Apache License, Version 2.0

diff --git a/lib/ohai/plugins/linux/block_device.rb b/lib/ohai/plugins/linux/block_device.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Adam Jacob (<[email protected]>)
 # Copyright:: Copyright (c) Chef Software Inc.

diff --git a/lib/ohai/plugins/linux/hostnamectl.rb b/lib/ohai/plugins/linux/hostnamectl.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Davide Cavalca (<[email protected]>)
 # Copyright:: Copyright (c) 2016 Facebook

diff --git a/lib/ohai/plugins/linux/interrupts.rb b/lib/ohai/plugins/linux/interrupts.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Davide Cavalca <[email protected]>
 # Copyright:: Copyright (c) 2020 Facebook

diff --git a/lib/ohai/plugins/linux/ipc.rb b/lib/ohai/plugins/linux/ipc.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Author:: Jay Vana <[email protected]>
 # Author:: Davide Cavalca <[email protected]>