Resolve Style/RedundantSort warnings

Avoid a sort then last and just grab the max. Signed-off-by: Tim Smith <[email protected]>
skillstream · Sep 16, 2020 · 1ce3174 · 1ce3174
1 parent 40c71d4
commit 1ce3174
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/chef-bin/Rakefile b/chef-bin/Rakefile
@@ -10,7 +10,7 @@ Bundler::GemHelper.install_tasks
 desc "force install the chef-bin gem"
 task "install:force" do
   sh "gem build -V chef-bin.gemspec"
-  built_gem_path = Dir["chef-bin-*.gem"].sort_by { |f| File.mtime(f) }.last
+  built_gem_path = Dir["chef-bin-*.gem"].max_by { |f| File.mtime(f) }
   FileUtils.mkdir_p("pkg") unless Dir.exist?("pkg")
   FileUtils.mv(built_gem_path, "pkg")
   sh "gem install -f pkg/#{built_gem_path}"

diff --git a/lib/chef/mixin/versioned_api.rb b/lib/chef/mixin/versioned_api.rb
@@ -50,8 +50,7 @@ def get_class_for(type)
           # in which case we'll just start with the highest version and see what happens
           ServerAPIVersions.instance.min_server_version.nil? || (version >= ServerAPIVersions.instance.min_server_version && version <= ServerAPIVersions.instance.send(type))
         end
-          .sort { |a, b| a.send(:minimum_api_version) <=> b.send(:minimum_api_version) }
-          .last
+          .max { |a, b| a.send(:minimum_api_version) <=> b.send(:minimum_api_version) }
       end
 
       def def_versioned_delegator(method)