Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/2090 Improve Sgx error logs #2091

Closed
wants to merge 2 commits into from
Closed

Enhancement/2090 Improve Sgx error logs #2091

wants to merge 2 commits into from

Conversation

PropzSaladaz
Copy link

@PropzSaladaz PropzSaladaz commented Jan 31, 2025 •
edited
Loading

Description

  • Added error logs for SGX non-existent BLS & ECDSA key names
  • Improved log when blocks cannot be deserialized due to incorrect BLS key shares

Tests

  • Tested in local servers

@PropzSaladaz PropzSaladaz added the enhancement New feature or request label Jan 31, 2025
@PropzSaladaz PropzSaladaz added this to the SKALE 4.0 milestone Jan 31, 2025
@PropzSaladaz PropzSaladaz self-assigned this Jan 31, 2025
@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@PropzSaladaz PropzSaladaz changed the title Improve Sgx error logs Enhancement/2090 Improve Sgx error logs Jan 31, 2025
@PropzSaladaz PropzSaladaz linked an issue Jan 31, 2025 that may be closed by this pull request
Add more informative SGX related logs skalenetwork/skale-consensus#841
Closed
@PropzSaladaz PropzSaladaz deleted the enhancement/2090-improve-sgx-logs branch February 6, 2025 11:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olehnikolaiev olehnikolaiev Awaiting requested review from olehnikolaiev

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko DmytroNazarenko is a code owner

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees

@PropzSaladaz PropzSaladaz

Labels
enhancement New feature or request
Projects
None yet
Milestone
SKALE 4.0
Development

Successfully merging this pull request may close these issues.

Add more informative SGX related logs
1 participant
@PropzSaladaz