Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus 856 fix memory leak in db #2084

Merged
merged 5 commits into from
Feb 12, 2025
Merged

consensus 856 fix memory leak in db #2084

merged 5 commits into from
Feb 12, 2025

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Jan 28, 2025 •
edited
Loading

fixes skalenetwork/skale-consensus#856

fixed memory leak in CacheLevelDB
no memory leak found for skaled built with -DSANITIZE=addrss option after applying the fix

tested on the devnet - run load test, consensus dbs successfully rotated without crashes

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@DmytroNazarenko DmytroNazarenko added this to the SKALE 4.0 milestone Jan 31, 2025
@olehnikolaiev olehnikolaiev linked an issue Feb 5, 2025 that may be closed by this pull request
memory leak in CacheLevleDB skalenetwork/skale-consensus#856
Closed
@olehnikolaiev olehnikolaiev marked this pull request as ready for review February 11, 2025 11:04
@olehnikolaiev olehnikolaiev merged commit 1a5fcca into v4.0.0 Feb 12, 2025
5 checks passed
@olehnikolaiev olehnikolaiev deleted the consensus-856-memory-leak branch February 12, 2025 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kladkogex kladkogex kladkogex approved these changes

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SKALE 4.0
Development

Successfully merging this pull request may close these issues.

memory leak in CacheLevleDB
3 participants
@olehnikolaiev @kladkogex @DmytroNazarenko