Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not increase failed_rpc_count when Rpc status is False #1143

Open
wants to merge 3 commits into
base: v2.10.x
Choose a base branch
from

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Jan 29, 2025

Changes

  • Do not increase failed_rpc_count while Rpc status is false in skaled.status file

Performance

  • No performance related changes were introduced

Testing

  • Modified unit tests
  • Tested on local network

Related skaled pr: skalenetwork/skaled#2093

@badrogger badrogger changed the title Do not increase failed_rpc_counter when Rpc status is False Do not increase failed_rpc_count when Rpc status is False Jan 29, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.42%. Comparing base (f45ac0a) to head (5292cf3).

Files with missing lines Patch % Lines
core/schains/monitor/rpc.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v2.10.x    #1143      +/-   ##
===========================================
+ Coverage    81.41%   81.42%   +0.01%     
===========================================
  Files          103      103              
  Lines         6570     6574       +4     
===========================================
+ Hits          5349     5353       +4     
  Misses        1221     1221              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review February 4, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaled not starts from the catchup for a long time after recreation of skaled-container
1 participant