Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust the timing of defining theorems #58

Closed
wants to merge 1 commit into from
Closed

fix: adjust the timing of defining theorems #58

wants to merge 1 commit into from

Conversation

NemoYuan2008
Copy link
Contributor

将定义定理环境的位置从 amsthm/ntheorem 宏包结束调整到导言区结束,理由如下:

  1. 解决 sjtuthesis 文档类与 thmtools 宏包的 \listoftheorems 不兼容 #57 中的问题;
  2. 如果使用 cleveref 宏包,应在加载 cleveref 之后才定义定理环境(见 texdoc cleveref 第25页第2条)。

@AlexaraWu
Copy link
Collaborator

为什么关闭了 😂?直接改一下就好了,等下可以 squash。

测试不通过是 ctxdoc.cls 的问题,主分支里我已经改过了,不影响的。

@NemoYuan2008
Copy link
Contributor Author

我之前在 Windows 上弄的,因为没有 Ubuntu fontset 就没测试 l3build doc,刚刚看测试不通过,我换实验室的 Ubuntu 电脑本地试了一下,确实 l3build doc 会 fail,稍等我再看看

@NemoYuan2008
Copy link
Contributor Author

重新提交了一下,见 #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants