Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to chakra 3 #84

Merged
merged 16 commits into from
Dec 2, 2024
Merged

bump to chakra 3 #84

merged 16 commits into from
Dec 2, 2024

Conversation

dtemkin1
Copy link
Collaborator

@dtemkin1 dtemkin1 commented Nov 30, 2024

Bumps version of Chakra UI, mainly followed migration guide (which is the reason for the components/ui folder) but also made some of the following changes:

  • Manually set the variant of buttons to "subtle" to match how Hydrant already looks like, same with setting every link component to blue
  • Using component select component instead of native select. Whenever the theme was dark the options were all unreadable before :(
  • For some reason when we clicking an event on the calendar the click event isn't firing? Seems to be getting constantly re-rendered so refactored the Calendar.tsx file a bit to try things out but couldn't get it working consistently. If someone better at React knows whats going on pls lmk :/
  • Prettier touched a lot of files, sorry for the massive diff

If I missed something, let me know! :D

src/lib/utils.tsx Outdated Show resolved Hide resolved
@dtemkin1 dtemkin1 reopened this Nov 30, 2024
@dtemkin1 dtemkin1 requested a review from psvenk November 30, 2024 21:06
Copy link
Member

@psvenk psvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good to me, code-wise and functionality-wise. I have a few comments, though:

  • As you noted, the click event doesn't consistently fire when clicking on a class/activity on the calendar; strangely, this issue also exists for the buttons in the description of a custom activity (for changing its properties).
  • In general, I have mixed feelings about how this affects the general design language used in Hydrant. I personally prefer the more defined features of the old design; in particular, what are your thoughts on bringing back the smaller spaces between selected classes/activities, larger font size for selected class/activity names, and even thicker font weights and rounder corners?

For reference:

Before:
hydrant mit edu_

After:
localhost_3000_

@dtemkin1
Copy link
Collaborator Author

dtemkin1 commented Dec 2, 2024

I made a few style changes to make it look more like it did before, let me know if that helps. The two things that I'm struggling with (and maybe someone with better React knowledge can help with this?) and should be fixed before merging are:

  • The text being shown by a tooltip component is appearing below other things (eg. buttons, the table header, etc.). I'm not sure if we have to do things with refs or something, but if someone knows how to fix this (and has a bit more time than me to work on this), please let me know!
  • The calendar component seems to be rerendering events constantly, which is making it so that clicking events doesn't work (and also just making the website slower I think). I poked around and it seems that React thinks that the props given to the Calendar component (specifically, selectedActivities) is constantly changing. I tried to revert most things that touch the Calendar component back to how they were originally, but I'm not really sure why this is happening.

@dtemkin1 dtemkin1 requested a review from psvenk December 2, 2024 02:32
@dtemkin1 dtemkin1 merged commit 96a2e15 into sipb:main Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants