-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to chakra 3 #84
bump to chakra 3 #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good to me, code-wise and functionality-wise. I have a few comments, though:
- As you noted, the click event doesn't consistently fire when clicking on a class/activity on the calendar; strangely, this issue also exists for the buttons in the description of a custom activity (for changing its properties).
- In general, I have mixed feelings about how this affects the general design language used in Hydrant. I personally prefer the more defined features of the old design; in particular, what are your thoughts on bringing back the smaller spaces between selected classes/activities, larger font size for selected class/activity names, and even thicker font weights and rounder corners?
For reference:
I made a few style changes to make it look more like it did before, let me know if that helps. The two things that I'm struggling with (and maybe someone with better React knowledge can help with this?) and should be fixed before merging are:
|
Bumps version of Chakra UI, mainly followed migration guide (which is the reason for the components/ui folder) but also made some of the following changes:
If I missed something, let me know! :D