Fixes in MPContestController #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
geoff128
commented
Mar 7, 2023
geoff128
commented
- There was an error when participant tried to access contest with problem with no round
- Scores were not visible on problems list
|
It would be nice if the ranking had the usual colors. I think they are missing because of the non-integer scores, which in my humble opinion are not needed. |
twalen
reviewed
Apr 3, 2023
oioioi/mp/controllers.py
Outdated
| ) | ||
| except SubmissionReport.DoesNotExist: | ||
| report = None | ||
|
|
||
| result.score = best_submission[1] |
There was a problem hiding this comment.
I suggest to change typo of best_submission from tuple to normal variable and use following logic
- best_submission (currently best submission)
- add new variable best_submission_score (initially None, currently best score)
This would make this part of the code much more readable.
twalen
requested changes
Apr 3, 2023
|
@geoff128 Could You please try to look into this by EOY? |
MasloMaslane
approved these changes
Dec 11, 2023
twalen
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.