Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake.nix: Split nixos module to a separate file #18

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

benley
Copy link
Collaborator

@benley benley commented Jan 22, 2025

  • Split out nix/nixos-module.nix. This way it can theoretically be imported without using flakes, since some people prefer to do things that way.
  • Use a nixpkgs overlay to add tailscale-manager to pkgs, so it shows up when vm-text.nix imports the module
  • Move nixosModules to the system-independent outputs section where it belongs
  • Remove the last references to packageName since we were not using it consistently

Resources: https://vtimofeenko.com/posts/practical-nix-flake-anatomy-a-guided-tour-of-flake.nix/

- Split out nix/nixos-module.nix. This way it can theoretically be
  imported without using flakes, since some people prefer to do things
  that way.
- Use a nixpkgs overlay to add tailscale-manager to pkgs, so it shows up
  when vm-text.nix imports the module
- Move nixosModules to the system-independent outputs section where it
  belongs
- Remove last references to `packageName` since we were not using it
  consistently

Resources: https://vtimofeenko.com/posts/practical-nix-flake-anatomy-a-guided-tour-of-flake.nix/
@benley benley force-pushed the split-nixos-module branch from 0b718a0 to b72b13f Compare January 22, 2025 18:32
@benley benley requested a review from marek-memsql January 24, 2025 16:49
@benley benley merged commit e8bf6e6 into singlestore-labs:main Jan 24, 2025
6 checks passed
@benley benley deleted the split-nixos-module branch January 24, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant