Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant import warnings #17

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

benley
Copy link
Collaborator

@benley benley commented Jan 22, 2025

These were introduced in eddf6d6

src/TailscaleManager/Config.hs:6:1: warning: [-Wunused-imports]
    The import of ‘Data.Aeson’ is redundant
      except perhaps to import instances from ‘Data.Aeson’
    To import instances alone, use: import Data.Aeson()
  |
6 | import Data.Aeson (eitherDecodeFileStrict)
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/TailscaleManager/Config.hs:8:1: warning: [-Wunused-imports]
    The qualified import of ‘Data.ByteString.Lazy’ is redundant
      except perhaps to import instances from ‘Data.ByteString.Lazy’
    To import instances alone, use: import Data.ByteString.Lazy()
  |
8 | import Data.ByteString.Lazy qualified as LB
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

These were introduced in eddf6d6
@benley benley requested a review from dhyanio January 22, 2025 16:46
Copy link
Contributor

@dhyanio dhyanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhyanio dhyanio merged commit 4aa945b into singlestore-labs:main Jan 23, 2025
6 checks passed
@benley benley deleted the redundant-imports branch January 23, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants