Fix test

simplesamlphp · Jul 16, 2024 · d5fedb0 · d5fedb0
1 parent 781739e
commit d5fedb0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Cas/Protocol/Cas20.php b/src/Cas/Protocol/Cas20.php
@@ -117,9 +117,9 @@ public function getProxyGrantingTicketIOU(): ?string
 
     /**
      * @param string $username
-     * @return \SimpleSAML\CAS\XML\cas\AuthenticationSuccess
+     * @return \SimpleSAML\CAS\XML\cas\ServiceResponse
      */
-    public function getValidateSuccessResponse(string $username): AuthenticationSuccess
+    public function getValidateSuccessResponse(string $username): ServiceResponse
     {
         $user = new User($username);
 
@@ -157,9 +157,10 @@ public function getValidateSuccessResponse(string $username): AuthenticationSucc
             $attr,
         );
 
-        $authenticationSucces = new AuthenticationSuccess($user, $attributes, $proxyGrantingTicket);
+        $authenticationSuccess = new AuthenticationSuccess($user, $attributes, $proxyGrantingTicket);
+        $serviceResponse = new ServiceResponse($authenticationSuccess);
 
-        return $authenticationSucces;
+        return $serviceResponse;
     }
 
 

diff --git a/tests/src/Cas/Protocol/Cas20Test.php b/tests/src/Cas/Protocol/Cas20Test.php
@@ -54,6 +54,6 @@ public function testAttributeToXmlConversion(): void
 
         $xml = $casProtocol->getValidateSuccessResponse('myUser');
 
-        $this->assertEquals($this->document->saveXML(), $xml);
+        $this->assertEquals($this->document->saveXML(), strval($xml));
     }
 }