coding style: trailing comma #150
php.yml
on: push
Annotations
33 errors and 15 warnings
PossiblyUndefinedArrayOffset:
public/cas.php#L40
public/cas.php:40:20: PossiblyUndefinedArrayOffset: Possibly undefined array key $_SERVER['PATH_INFO'] on array{APP_DEBUG?: bool|string, APP_ENV?: string, AUTH_TYPE?: non-empty-string, CONTENT_LENGTH?: string, CONTENT_TYPE?: string, DOCUMENT_ROOT?: non-empty-string, FCGI_ROLE?: non-empty-string, GATEWAY_INTERFACE?: non-empty-string, HOME?: non-empty-string, HTTPS?: string, HTTP_ACCEPT?: non-empty-string, HTTP_ACCEPT_CHARSET?: non-empty-string, HTTP_ACCEPT_ENCODING?: non-empty-string, HTTP_ACCEPT_LANGUAGE?: non-empty-string, HTTP_CACHE_CONTROL?: non-empty-string, HTTP_CDN_LOOP?: non-empty-string, HTTP_CF_CONNECTING_IP?: non-empty-string, HTTP_CF_IPCOUNTRY?: non-empty-string, HTTP_CF_VISITOR?: non-empty-string, HTTP_CLIENT_IP?: non-empty-string, HTTP_CONNECTION?: non-empty-string, HTTP_COOKIE?: non-empty-string, HTTP_DNT?: non-empty-string, HTTP_HOST?: non-empty-string, HTTP_PRIORITY?: non-empty-string, HTTP_REFERER?: non-empty-string, HTTP_SEC_CH_UA?: non-empty-string, HTTP_SEC_CH_UA_MOBILE?: non-empty-string, HTTP_SEC_CH_UA_PLATFORM?: non-empty-string, HTTP_SEC_FETCH_DEST?: non-empty-string, HTTP_SEC_FETCH_MODE?: non-empty-string, HTTP_SEC_FETCH_SITE?: non-empty-string, HTTP_SEC_FETCH_USER?: non-empty-string, HTTP_UPGRADE_INSECURE_REQUESTS?: non-empty-string, HTTP_USER_AGENT?: non-empty-string, HTTP_X_FORWARDED_FOR?: non-empty-string, HTTP_X_FORWARDED_PROTO?: non-empty-string, HTTP_X_REAL_IP?: non-empty-string, ORIG_PATH_INFO?: non-empty-string, PATH?: non-empty-string, PATH_INFO?: non-empty-string, PATH_TRANSLATED?: non-empty-string, PHP_AUTH_DIGEST?: non-empty-string, PHP_AUTH_PW?: non-empty-string, PHP_AUTH_USER?: non-empty-string, PHP_SELF?: non-empty-string, QUERY_STRING?: string, REDIRECT_REMOTE_USER?: non-empty-string, REDIRECT_STATUS?: non-empty-string, REMOTE_ADDR?: non-empty-string, REMOTE_HOST?: non-empty-string, REMOTE_PORT?: string, REMOTE_USER?: non-empty-string, REQUEST_METHOD?: non-empty-string, REQUEST_SCHEME?: non-empty-string, REQUEST_TIME?: int<1720629673, max>, REQUEST_TIME_FLOAT?: float, REQUEST_URI?: non-empty-string, SCRIPT_FILENAME?: non-empty-string, SCRIPT_NAME?: non-empty-string, SERVER_ADDR?: non-empty-string, SERVER_ADMIN?: non-empty-string, SERVER_NAME?: non-empty-string, SERVER_PORT?: non-empty-string, SERVER_PROTOCOL?: non-empty-string, SERVER_SIGNATURE?: non-empty-string, SERVER_SOFTWARE?: non-empty-string, USER?: non-empty-string, argc?: int<1, max>, argv?: non-empty-list<string>, ...<non-empty-string, string>} (see https://psalm.dev/167)
|
PossiblyNullArgument:
public/cas.php#L40
public/cas.php:40:20: PossiblyNullArgument: Argument 1 of substr cannot be null, possibly null value provided (see https://psalm.dev/078)
|
RiskyTruthyFalsyComparison:
public/login.php#L45
public/login.php:45:40: RiskyTruthyFalsyComparison: Operand of type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
RiskyTruthyFalsyComparison:
public/login.php#L46
public/login.php:46:41: RiskyTruthyFalsyComparison: Operand of type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
PossiblyInvalidArgument:
public/login.php#L56
public/login.php:56:69: PossiblyInvalidArgument: Argument 1 of sanitize expects string, but possibly different type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string provided (see https://psalm.dev/092)
|
RiskyTruthyFalsyComparison:
public/login.php#L110
public/login.php:110:9: RiskyTruthyFalsyComparison: Operand of type mixed|null contains type mixed, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
PossiblyInvalidArgument:
public/login.php#L230
public/login.php:230:69: PossiblyInvalidArgument: Argument 1 of SimpleSAML\Utils\HTTP::addURLParameters expects string, but possibly different type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string provided (see https://psalm.dev/092)
|
PossiblyInvalidArgument:
public/login.php#L232
public/login.php:232:36: PossiblyInvalidArgument: Argument 1 of SimpleSAML\Utils\HTTP::submitPOSTData expects string, but possibly different type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string provided (see https://psalm.dev/092)
|
PossiblyInvalidArgument:
public/logout.php#L82
public/logout.php:82:69: PossiblyInvalidArgument: Argument 1 of SimpleSAML\Utils\HTTP::addURLParameters expects string, but possibly different type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string provided (see https://psalm.dev/092)
|
UndefinedClass:
public/proxy.php#L101
public/proxy.php:101:45: UndefinedClass: Class, interface or enum named C does not exist (see https://psalm.dev/019)
|
Unit tests, PHP 8.2, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L154
Failed asserting that 404 matches expected 500.
|
Unit tests, PHP 8.2, ubuntu-latest:
tests/src/Cas/Protocol/Cas20Test.php#L57
Failed asserting that SimpleSAML\CAS\XML\cas\AuthenticationSuccess Object #478 (
|
Unit tests, PHP 8.2, ubuntu-latest:
tests/src/Cas/Protocol/SamlValidateTest.php#L34
Failed asserting that null matches expected 'localhost'.
|
Unit tests, PHP 8.2, ubuntu-latest
Process completed with exit code 2.
|
Unit tests, PHP 8.3, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L130
Failed asserting that 404 matches expected 200.
|
Unit tests, PHP 8.3, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L154
Failed asserting that 404 matches expected 500.
|
Unit tests, PHP 8.3, ubuntu-latest:
tests/src/Cas/Protocol/Cas20Test.php#L57
Failed asserting that SimpleSAML\CAS\XML\cas\AuthenticationSuccess Object #1312 (
|
Unit tests, PHP 8.3, ubuntu-latest:
tests/src/Cas/Protocol/SamlValidateTest.php#L34
Failed asserting that null matches expected 'localhost'.
|
Unit tests, PHP 8.3, ubuntu-latest
Process completed with exit code 2.
|
Unit tests, PHP 8.1, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L130
Failed asserting that 404 matches expected 200.
|
Unit tests, PHP 8.1, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L154
Failed asserting that 404 matches expected 500.
|
Unit tests, PHP 8.1, ubuntu-latest:
tests/src/Cas/Protocol/Cas20Test.php#L57
Failed asserting that SimpleSAML\CAS\XML\cas\AuthenticationSuccess Object #409 (
|
Unit tests, PHP 8.1, ubuntu-latest:
tests/src/Cas/Protocol/SamlValidateTest.php#L34
Failed asserting that null matches expected 'localhost'.
|
Unit tests, PHP 8.1, ubuntu-latest
Process completed with exit code 2.
|
Unit tests, PHP 8.3, windows-latest:
tests/public/LoginIntegrationTest.php#L130
Failed asserting that 404 matches expected 200.
|
Unit tests, PHP 8.3, windows-latest:
tests/public/LoginIntegrationTest.php#L154
Failed asserting that 404 matches expected 500.
|
Unit tests, PHP 8.3, windows-latest:
tests/src/Cas/Protocol/Cas20Test.php#L57
Failed asserting that SimpleSAML\CAS\XML\cas\AuthenticationSuccess Object #167 (
|
Unit tests, PHP 8.3, windows-latest:
tests/src/Cas/Protocol/SamlValidateTest.php#L34
Failed asserting that null matches expected 'localhost'.
|
Unit tests, PHP 8.3, windows-latest
Process completed with exit code 1.
|
Unit tests, PHP 8.1, windows-latest
The job was canceled because "windows-latest_8_3" failed.
|
Unit tests, PHP 8.1, windows-latest
The operation was canceled.
|
Unit tests, PHP 8.2, windows-latest
The job was canceled because "windows-latest_8_3" failed.
|
Unit tests, PHP 8.2, windows-latest
The operation was canceled.
|
DeprecatedFunction:
public/proxy.php#L43
public/proxy.php:43:5: DeprecatedFunction: The function checkserviceurl has been marked as deprecated (see https://psalm.dev/201)
|
DeprecatedFunction:
public/proxy.php#L102
public/proxy.php:102:12: DeprecatedFunction: The function checkserviceurl has been marked as deprecated (see https://psalm.dev/201)
|
PropertyNotSetInConstructor:
src/Cas/Ticket/DelegatingTicketStore.php#L33
src/Cas/Ticket/DelegatingTicketStore.php:33:25: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Cas\Ticket\DelegatingTicketStore::$primaryDelegate is not defined in constructor of SimpleSAML\Module\casserver\Cas\Ticket\DelegatingTicketStore or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
DeprecatedMethod:
src/Shib13/AuthnResponse.php#L498
src/Shib13/AuthnResponse.php:498:26: DeprecatedMethod: The method SimpleSAML\XML\Utils::xsDateTimeToTimestamp has been marked as deprecated (see https://psalm.dev/001)
|
DeprecatedMethod:
src/Shib13/AuthnResponse.php#L505
src/Shib13/AuthnResponse.php:505:24: DeprecatedMethod: The method SimpleSAML\XML\Utils::xsDateTimeToTimestamp has been marked as deprecated (see https://psalm.dev/001)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L39
tests/public/LoginIntegrationTest.php:39:29: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$server is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L44
tests/public/LoginIntegrationTest.php:44:22: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$server_addr is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L49
tests/public/LoginIntegrationTest.php:49:19: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$server_pid is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L54
tests/public/LoginIntegrationTest.php:54:22: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$shared_file is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L59
tests/public/LoginIntegrationTest.php:59:22: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$cookies_file is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PossiblyUndefinedArrayOffset:
tests/public/LoginIntegrationTest.php#L468
tests/public/LoginIntegrationTest.php:468:23: PossiblyUndefinedArrayOffset: Possibly undefined array key (see https://psalm.dev/167)
|
PossiblyInvalidArgument:
tests/public/LoginIntegrationTest.php#L468
tests/public/LoginIntegrationTest.php:468:52: PossiblyInvalidArgument: Argument 2 of explode expects string, but possibly different type string|true provided (see https://psalm.dev/092)
|
PossiblyUndefinedArrayOffset:
tests/public/LoginIntegrationTest.php#L473
tests/public/LoginIntegrationTest.php:473:25: PossiblyUndefinedArrayOffset: Possibly undefined array key (see https://psalm.dev/167)
|
DeprecatedFunction:
tests/public/UtilsTest.php#L46
tests/public/UtilsTest.php:46:39: DeprecatedFunction: The function checkserviceurl has been marked as deprecated (see https://psalm.dev/201)
|
PropertyNotSetInConstructor:
tests/src/Cas/Protocol/Cas20Test.php#L16
tests/src/Cas/Protocol/Cas20Test.php:16:27: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\Cas20Test::$document is not defined in constructor of SimpleSAML\Casserver\Cas20Test or in any methods called in the constructor (see https://psalm.dev/074)
|