-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/rails 5 2 6 #28
Open
luismiv85
wants to merge
14
commits into
features/landing-promo
Choose a base branch
from
features/rails-5-2-6
base: features/landing-promo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated rails minor versions - Removed github versions of Globalize, ActiveResource and Rails Observers - Fixed versions for pg and sqlite gems in Rails 5.0 and below - Updated gemfile.lock files for each appraisal with latest versions of gems
Rails 6 and Rails 4 demand a different version of Ruby so we had to include code to control ruby version. The code implies that the gemfiles by appraisal will be created and used only when certain ruby versions are being userd. Thus, the Rails 4.0 gemfiles will olny be used, and the tests run, when in a version below ruby 2.4.
gemfiles generated and specs run and passed in Rails 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to Rails 5.2 and 6