Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/rails 5 2 6 #28

Open
wants to merge 14 commits into
base: features/landing-promo
Choose a base branch
from

Conversation

luismiv85
Copy link

Support to Rails 5.2 and 6

viglesias and others added 14 commits January 18, 2017 10:08
- Updated rails minor versions
- Removed github versions of Globalize, ActiveResource and Rails Observers
- Fixed versions for pg and sqlite gems in Rails 5.0 and below
- Updated gemfile.lock files for each appraisal with latest versions of gems
Rails 6 and Rails 4 demand a different version of Ruby so we had to
include code to control ruby version.

The code implies that the gemfiles by appraisal will be created and used
only when certain ruby versions are being userd. Thus, the Rails 4.0
gemfiles will olny be used, and the tests run, when in a version below
ruby 2.4.
gemfiles generated and specs run and passed in Rails 6
@luismiv85 luismiv85 requested review from brenes and Guzmangm August 1, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants