lib: fix division by zero in roi when all assets are sold (fixes #2281)

simonmichael · Nov 7, 2024 · c006959 · c006959
1 parent d176215
commit c006959
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/hledger/Hledger/Cli/Commands/Roi.hs b/hledger/Hledger/Cli/Commands/Roi.hs
@@ -239,7 +239,9 @@ timeWeightedReturn styles showCashFlow prettyTables investmentsQuery trans mixed
                Left pnl' ->
                  -- PnL change
                  let valueAfterDate = valueOnDate + unMix pnl'
-                     unitCost' = valueAfterDate/unitBalance
+                     unitCost' =
+                       if unitBalance == 0 then initialUnitCost -- everything was sold, let's reset the cost to initial cost
+                       else valueAfterDate/unitBalance
                  in (valueOnDate, 0, unitCost', unitBalance))
           (0, 0, initialUnitCost, initialUnits)
           $ dbg3 "changes" changes