Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gcc-14 warnings #19

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

huangminghuang
Copy link
Contributor

This PR fixes the following warnings in gcc 14:

[build] ~/is_utf8/src/is_utf8.cpp:2571:36: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  2571 |   is_utf8_really_inline simd8<bool>() : base8() {}
[build]       |                                    ^
[build] ~/is_utf8/src/is_utf8.cpp:2571:36: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:2572:36: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  2572 |   is_utf8_really_inline simd8<bool>(const __m256i _value)
[build]       |                                    ^
[build] ~/is_utf8/src/is_utf8.cpp:2572:36: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:2575:36: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  2575 |   is_utf8_really_inline simd8<bool>(bool _value) : base8<bool>(splat(_value)) {}
[build]       |                                    ^
[build] ~/is_utf8/src/is_utf8.cpp:2575:36: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:3001:37: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  3001 |   is_utf8_really_inline simd16<bool>() : base16() {}
[build]       |                                     ^
[build] ~/is_utf8/src/is_utf8.cpp:3001:37: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:3002:37: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  3002 |   is_utf8_really_inline simd16<bool>(const __m256i _value)
[build]       |                                     ^
[build] ~/is_utf8/src/is_utf8.cpp:3002:37: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:3005:37: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  3005 |   is_utf8_really_inline simd16<bool>(bool _value)
[build]       |                                     ^
[build] ~/is_utf8/src/is_utf8.cpp:3005:37: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:3552:36: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  3552 |   is_utf8_really_inline simd8<bool>() : base8() {}
[build]       |                                    ^
[build] ~/is_utf8/src/is_utf8.cpp:3552:36: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:3553:36: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  3553 |   is_utf8_really_inline simd8<bool>(const __m128i _value)
[build]       |                                    ^
[build] ~/is_utf8/src/is_utf8.cpp:3553:36: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:3556:36: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  3556 |   is_utf8_really_inline simd8<bool>(bool _value) : base8<bool>(splat(_value)) {}
[build]       |                                    ^
[build] ~/is_utf8/src/is_utf8.cpp:3556:36: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:4068:37: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  4068 |   is_utf8_really_inline simd16<bool>() : base16() {}
[build]       |                                     ^
[build] ~/is_utf8/src/is_utf8.cpp:4068:37: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:4069:37: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  4069 |   is_utf8_really_inline simd16<bool>(const __m128i _value)
[build]       |                                     ^
[build] ~/is_utf8/src/is_utf8.cpp:4069:37: note: remove the ‘< >’
[build] ~/is_utf8/src/is_utf8.cpp:4072:37: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
[build]  4072 |   is_utf8_really_inline simd16<bool>(bool _value)
[build]       |                                     ^
[build] ~/is_utf8/src/is_utf8.cpp:4072:37: note: remove the ‘< >’

@lemire
Copy link
Member

lemire commented Sep 28, 2024

Running tests.

@lemire lemire merged commit 62e420a into simdutf:main Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants