Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int parsing #384

Merged

Conversation

Licenser
Copy link
Member

We falsly returned i64 for non negative numbers that were in the i64 range; fixes #383

@Licenser Licenser linked an issue Aug 23, 2024 that may be closed by this pull request
src/serde.rs Outdated Show resolved Hide resolved
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser Licenser force-pushed the 383-untagged-enums-incorrectly-deserialized-in-some-edge-cases branch from 1654e56 to 84c2343 Compare August 23, 2024 18:59
Signed-off-by: Heinz N. Gies <[email protected]>
Copy link

Benchmark for f37ae68

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 91.2±4.10µs 90.9±1.33µs -0.33%
canada/simd_json::to_tape_with_buffers 3.7±0.16ms 3.7±0.14ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1134.1±81.65µs 1132.6±74.85µs -0.13%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.20µs 3.7±0.21µs 0.00%
github_events/simd_json::to_tape_with_buffers 39.8±0.95µs 39.9±0.93µs +0.25%
log/simd_json::to_tape_with_buffers 1517.7±70.16ns 1578.7±73.38ns +4.02%
twitter/simd_json::to_tape_with_buffers 438.9±26.57µs 437.0±25.58µs -0.43%

Copy link

Benchmark for f08d03a

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 93.0±3.45µs 91.5±2.26µs -1.61%
canada/simd_json::to_tape_with_buffers 3.8±0.17ms 3.7±0.15ms -2.63%
citm_catalog/simd_json::to_tape_with_buffers 1135.5±83.09µs 1131.0±81.96µs -0.40%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.25µs 3.8±0.26µs 0.00%
github_events/simd_json::to_tape_with_buffers 40.2±1.26µs 40.7±1.28µs +1.24%
log/simd_json::to_tape_with_buffers 1548.3±76.62ns 1606.7±105.92ns +3.77%
twitter/simd_json::to_tape_with_buffers 446.1±28.89µs 445.3±29.43µs -0.18%

Copy link

Benchmark for a009936

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 92.4±2.35µs 91.7±1.55µs -0.76%
canada/simd_json::to_tape_with_buffers 3.8±0.16ms 3.9±0.13ms +2.63%
citm_catalog/simd_json::to_tape_with_buffers 1143.3±89.75µs 1133.9±83.52µs -0.82%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.9±0.31µs 3.8±0.31µs -2.56%
github_events/simd_json::to_tape_with_buffers 41.5±1.38µs 40.7±1.21µs -1.93%
log/simd_json::to_tape_with_buffers 1589.2±100.97ns 1585.8±97.85ns -0.21%
twitter/simd_json::to_tape_with_buffers 444.8±31.06µs 444.9±27.18µs +0.02%

@Licenser Licenser merged commit 6d197e2 into main Aug 23, 2024
23 checks passed
@Licenser Licenser deleted the 383-untagged-enums-incorrectly-deserialized-in-some-edge-cases branch August 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Untagged enums incorrectly deserialized in some edge cases
2 participants