Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic while fuzzing #371 #372

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Fix panic while fuzzing #371 #372

merged 3 commits into from
Mar 20, 2024

Conversation

Licenser
Copy link
Member

@CleveGreen thanks for the report, this should resolve the crash in the fuzzer.

Also clean up some clippy warnings

Signed-off-by: Heinz Gies <[email protected]>
Copy link

Benchmark for 95c7644

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 93.4±1.68µs 92.8±2.05µs -0.64%
canada/simd_json::to_tape_with_buffers 3.7±0.13ms 3.7±0.16ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1141.1±78.79µs 1125.7±76.22µs -1.35%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 4.0±0.28µs 4.0±0.25µs 0.00%
github_events/simd_json::to_tape_with_buffers 41.4±1.22µs 40.9±0.96µs -1.21%
log/simd_json::to_tape_with_buffers 1624.7±96.24ns 1597.3±84.79ns -1.69%
twitter/simd_json::to_tape_with_buffers 451.3±28.23µs 446.5±26.24µs -1.06%

Signed-off-by: Heinz Gies <[email protected]>
Copy link

Benchmark for fd3a0df

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 92.4±3.81µs 93.5±1.76µs +1.19%
canada/simd_json::to_tape_with_buffers 3.6±0.16ms 3.8±0.15ms +5.56%
citm_catalog/simd_json::to_tape_with_buffers 1123.4±82.46µs 1122.9±83.20µs -0.04%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.24µs 3.8±0.28µs 0.00%
github_events/simd_json::to_tape_with_buffers 40.8±1.26µs 41.1±1.01µs +0.74%
log/simd_json::to_tape_with_buffers 1581.1±101.49ns 1599.4±104.46ns +1.16%
twitter/simd_json::to_tape_with_buffers 437.9±26.49µs 438.4±28.70µs +0.11%

@Licenser Licenser linked an issue Mar 20, 2024 that may be closed by this pull request
Copy link

Benchmark for d706699

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 91.7±2.58µs 92.8±2.06µs +1.20%
canada/simd_json::to_tape_with_buffers 3.7±0.16ms 3.6±0.16ms -2.70%
citm_catalog/simd_json::to_tape_with_buffers 1142.1±91.58µs 1131.8±84.11µs -0.90%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.9±0.27µs 3.9±0.33µs 0.00%
github_events/simd_json::to_tape_with_buffers 41.0±2.21µs 41.1±1.45µs +0.24%
log/simd_json::to_tape_with_buffers 1593.0±109.38ns 1631.5±107.77ns +2.42%
twitter/simd_json::to_tape_with_buffers 451.0±30.68µs 453.2±28.07µs +0.49%

@Licenser Licenser merged commit f4b482e into main Mar 20, 2024
23 of 25 checks passed
@Licenser Licenser deleted the fix-fuzz-crash branch March 20, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic while fuzzing
1 participant