Expose the fields of Error as public
#369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I totally see the use on that, instead of making the fields public would it work for you to add accessor functions? That way, keeping the fields private, allows to change them in the future as needed without forcing users to adopt their code as long as the functions can wrap the new data layout into the old functions. |
|
@Licenser sorry, took a while for me to get back to this but this should be done now :) |
Licenser
approved these changes
Apr 8, 2024
auto-merge was automatically disabled
April 15, 2024 11:32
Head branch was pushed to by a user without write access
|
thanks! released as 0.13.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields can be useful when trying to inspect the error.