Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility on unsupported CPU architectures #364

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

liushuyu
Copy link
Contributor

This pull request fixes the issue where the simd-json fallback code path isn't working for unsupported CPU architectures.

#[allow(dead_code)] is added for the handle_unicode_codepoint function since this function is not used when building the fallback logic.

An alternative method would be changing the Cargo.toml file to gate runtime-detection feature behind x86_64 and x86 architectures.

Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks!

@Licenser Licenser merged commit f46dc2a into simd-lite:main Jan 20, 2024
23 of 24 checks passed
@Licenser
Copy link
Member

released as 0.13.8 thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants