API Rename FormField Value to getFormattedValue

silverstripe · Jan 29, 2025 · 6a92ece · 6a92ece
1 parent 971ba30
commit 6a92ece
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/code/FormField/UserFormsCheckboxSetField.php b/code/FormField/UserFormsCheckboxSetField.php
@@ -47,7 +47,7 @@ public function getOptions()
 
     public function getValueForValidation(): mixed
     {
-        $value = $this->Value();
+        $value = $this->getValue();
         if (is_iterable($value) || is_null($value)) {
             return $value;
         }

diff --git a/code/Model/Submission/SubmittedFileField.php b/code/Model/Submission/SubmittedFileField.php
@@ -36,10 +36,8 @@ class SubmittedFileField extends SubmittedFormField
     /**
      * Return the value of this field for inclusion into things such as
      * reports.
-     *
-     * @return string
      */
-    public function getFormattedValue()
+    public function getFormattedValue(): ?DBField
     {
         $name = $this->getFileName();
         $link = $this->getLink(false);
@@ -77,7 +75,7 @@ public function getFormattedValue()
                 ));
             }
         }
-        return false;
+        return null;
     }
 
     /**

diff --git a/tests/php/Model/EditableFormField/EditableCountryDropdownFieldTest.php b/tests/php/Model/EditableFormField/EditableCountryDropdownFieldTest.php
@@ -38,7 +38,7 @@ public function testDefaultValue()
         /** @var EditableCountryDropdownField $field */
         $field = EditableCountryDropdownField::create();
         $field->Default = 'nz';
-        $this->assertEquals($field->getFormField()->Value(), 'nz');
+        $this->assertEquals($field->getFormField()->getValue(), 'nz');
     }
 
     public function testEmptyDefaultValue()