Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few deprecation fixes #11544

Merged
merged 3 commits into from
Jan 13, 2025
Merged

A few deprecation fixes #11544

merged 3 commits into from
Jan 13, 2025

Conversation

GuySartorelli
Copy link
Member

There's three distinct commits here. DO NOT SQUASH

  1. Fixes error with deprecation notice - if there's no backtrace, it was throwing an error. This is the case with the new deprecation notice I've added in commit 2.
  2. Add deprecation notice if the old i18n template syntax is used. No changelog entry required, it was already deprecated just had no notice.
  3. Stop calling a deprecated static method from templates. This is the same code used in CMS 6 and avoids an unnecessary deprecation warning that would otherwise happen on every template render on the frontend.

Issue

@GuySartorelli GuySartorelli mentioned this pull request Jan 10, 2025
Closed
2 tasks
@emteknetnz emteknetnz merged commit 0aa00a6 into silverstripe:5 Jan 13, 2025
18 checks passed
@emteknetnz emteknetnz deleted the pulls/5/deprecate-old-syntax branch January 13, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz