DEP Upgrade bootstrap and reactstrap #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
force-pushed
the
pulls/6.0/upgrade-bootstrap
branch
from
7e7b26d to
3d0c764
Compare
GuySartorelli
commented
Jan 23, 2025
| max-width: 900px; | ||
| width: 900px; |
There was a problem hiding this comment.
The bootstrap styling changed to using width instead of max-width so this needed to be changed to match
Comment on lines
-8
to
-23
| // Fixes issue when rendering reactstrap tooltip | ||
| // Warning: `NaN` is an invalid value for the `left` css style property. | ||
| // https://stackoverflow.com/a/70157330 | ||
| // Have refactored to not use an anonymous class with a static property being assigned | ||
| // so that it passed eslint | ||
| jest.mock('popper.js', () => { | ||
| const PopperJS = jest.requireActual('popper.js'); | ||
| return { | ||
| __esModule: true, | ||
| default: jest.fn(() => ({ | ||
| placements: PopperJS.placements, | ||
| destroy: () => {}, | ||
| scheduleUpdate: () => {}, | ||
| })), | ||
| }; | ||
| }); |
Comment on lines
+6
to
+8
| .form-label { | ||
| margin-bottom: 0; | ||
| } |
There was a problem hiding this comment.
Counteracts bootstrap adding a margin for this which broke the "display title?" checkbox styling.
emteknetnz
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See silverstripe/silverstripe-admin#1889 which links to the specific upgrade guide entries for most changes made.
Upgrade docs
Issue