API Rename FormField Value to getFormattedValue #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emteknetnz
force-pushed
the
pulls/6.0/rename-ffv
branch
2 times, most recently
from
554552d to
b420ad1
Compare
emteknetnz
force-pushed
the
pulls/6.0/rename-ffv
branch
3 times, most recently
from
f2633f7 to
4fd13fe
Compare
emteknetnz
force-pushed
the
pulls/6.0/rename-ffv
branch
from
4fd13fe to
54e3edf
Compare
emteknetnz
force-pushed
the
pulls/6.0/rename-ffv
branch
from
54e3edf to
9835716
Compare
GuySartorelli
requested changes
Feb 3, 2025
Comment on lines
-459
to
+462
| $params = [$fieldName, $messageText, $messageType, null, $messageCast]; | ||
| $params = [$fieldName, $messageText, $messageType, '', $messageCast]; | ||
| $validationResultWithNameSpaces->addFieldError(...$params); | ||
| } else { | ||
| $validationResultWithNameSpaces->addError($messageText, $messageType, null, $messageCast); | ||
| $validationResultWithNameSpaces->addError($messageText, $messageType, '', $messageCast); |
There was a problem hiding this comment.
This doesn't seem relevant? Looks like #1311 accidentally snuck into this PR?
There was a problem hiding this comment.
Probably makes sense to block this PR until the other one is merged, then rebase this PR and these changes should vanish
Comment on lines
-106
to
+107
| $showTitle->Value() === 'Yes' ? $displayedText : $notDisplayedText | ||
| // Intentionally using getValue() instead of getFormattedValue() to get the raw value | ||
| $showTitle->getValue() === 'Yes' ? $displayedText : $notDisplayedText |
There was a problem hiding this comment.
Why do we want to check against the raw value here? ShowTitle is a CheckboxField which will by default use ints 1 and 0 (but probably allows other value types) so this condition will often fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11468