-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT Add tests for multi-WYSIWYG config regressions #1135
MNT Add tests for multi-WYSIWYG config regressions #1135
Conversation
use SilverStripe\Forms\HTMLEditor\HTMLEditorField; | ||
|
||
/** | ||
* @extends Extension<BaseElement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds no benefit but does no harm in 4.x.
In 5.x it tells your IDE what $this->owner
and $this->getOwner()
are.
d496200
to
97166fb
Compare
97166fb
to
f58b935
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should be in admin, not elemental?
Relies on elemental blocks - has to be in elemental. Update: I have tried to reproduce this without elemental and haven't been able to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is fine, CI is red
Rerunning CI - as per PR description it needed the others merged first before it could go green. |
Description
Tests for regressions for having multiple WYSIWYG configs.
Tests are for silverstripe/silverstripe-admin#1512 and #1120
Needs all three of the below PRs to be merged for the CI to go green:
Manual testing steps
Load up an environment with the three linked PRs included, and run the new behat test.
Issues
Pull request checklist