NEW SudoModePasswordField component #1896
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/2/form-sudo-mode
branch
3 times, most recently
from
e7bc942 to
6313c22
Compare
emteknetnz
commented
Feb 3, 2025
code/LeftAndMain.php
Outdated
| @@ -1540,6 +1540,12 @@ public function getEditForm($id = null, $fields = null) | |||
| $readonlyFields = $form->Fields()->makeReadonly(); | |||
| $form->setFields($readonlyFields); | |||
| } | |||
|
|
|||
| // Sudo mode | |||
There was a problem hiding this comment.
Scenario is editing an individual record that is a record managed by a gridfield e.g. CMSProfileController will use this when editing the logged in users profile
emteknetnz
commented
Feb 3, 2025
code/ModelAdmin.php
Outdated
| @@ -274,6 +274,13 @@ public function getEditForm($id = null, $fields = null) | |||
| $form->setFormAction($editFormAction); | |||
| $form->setAttribute('data-pjax-fragment', 'CurrentForm'); | |||
|
|
|||
| // Sudo mode | |||
There was a problem hiding this comment.
Scenario is a managed model on a model admin, for instance Member on SecurityAdmin (which extends ModelAdmin)
emteknetnz
force-pushed
the
pulls/2/form-sudo-mode
branch
2 times, most recently
from
d5e63ef to
cd2a595
Compare
emteknetnz
force-pushed
the
pulls/2/form-sudo-mode
branch
from
cd2a595 to
10a7494
Compare
emteknetnz
commented
Feb 5, 2025
| function SudoModePasswordField(props) { | ||
| const { | ||
| className, | ||
| panelPadded, |
There was a problem hiding this comment.
The "panelPadded" functionality in this PR is related to making the field looking pretty "inline" which is only used in that PR which I think we should close. If we close that, then the panelPadded functionality should be removed from this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/589