ENH CMS 6 compatibility

[emteknetnz]

Issue silverstripe/.github#350

Needs silverstripe/supported-modules#49 merged before CI will work

Changes silverstripe/closure dependency to laravel/serializable-closure

Also a bunch of other maintenance changes to make this compatible with a CMS 6 install to ensure things work correctly in CI

Create a 5.0 branch after this is merged and tag 5.0.0-beta1, though we could arguably just release it straight to stable

[GuySartorelli]

I assume this needs silverstripe/supported-modules#49 to go green....

Though the error is "No valid PHP version allowed". I thought it used the php dependency from composer.json as a fallback? Seems we should definitely investigate that and fix it if needed rather than arbitrarily dropping this into the supported modules json.

[emteknetnz]

I thought it used the php dependency from composer.json

It would, expect this module does not actually require silverstripe so CI cannot just look at the version of framework in composer.json

[GuySartorelli]

I thought it used the php dependency from composer.json

It would, expect this module does not actually require silverstripe so CI cannot just look at the version of framework in composer.json

What does the version of framework have to do with it? The composer.json file for this repo has php as a dependency explicitly in the require section.

Edit: I've just had a look and isAllowedPhpVersion does check the composer php constraint before anything else.
I'm hesitant to merge silverstripe/supported-modules#49 because it seems like it's just working around a legitimate bug in generate matrix.

[emteknetnz]

I think isAllowedPhpVersion() checks to see if a particular version of php is allowed given the current composer.json being used

Before that a list of valid PHP versions is generated, e.g. for cms 6 it is 8.3 and 8.4

However doorman is not aware of what version of the cms is being used, because there isn't a version of framework, or admin etc in composer.json which can be used to derive the version of installer to use

Hence it's given the error "No valid PHP version allowed", cos the list of allowable PHP versions is empty

[GuySartorelli]

Ahhhh yup you're right. Probably that's something we ought to change but not right now.
Eventually getListOfPhpVersionsByBranchName will swap to using 5 as a fallback (or MetaData::LOWEST_SUPPORTED_CMS_MAJOR which will also swap to 5) and that will use more modern PHP versions.

For now, the change you've made is correct.

[GuySartorelli]

MOG

Create a 5.0 branch after this is merged and tag 5.0.0-beta1, though we could arguably just release it straight to stable

Wouldn't it be alpha1 not beta1?
In any case I think since this isn't a supported repo it doesn't need to go through the alpha->beta->rc->stable cycle. Feel free to tag as stable if you think that's more appropriate.
We might forget to tag the stable if we don't do it right away so that's probably best.

[GuySartorelli]

Matrix still refusing to build

[emteknetnz]

I've created a PR which should resolve silverstripe/gha-generate-matrix#115

[GuySartorelli]

LGTM