Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement FLC #6

Merged
merged 6 commits into from
Jan 29, 2025
Merged

feat: implement FLC #6

merged 6 commits into from
Jan 29, 2025

Conversation

WhiteHoodHacker
Copy link
Member

Closes #3

@WhiteHoodHacker WhiteHoodHacker self-assigned this Jan 22, 2025
@Sandvoxel
Copy link

Recommend added example linker file or add some docs to the readme on how to setup the linker file.

@Sandvoxel
Copy link

Also I see that you are trying to use the embedded ecosystem so you might want to take a look at https://github.com/rust-embedded-community/embedded-storage

@WhiteHoodHacker
Copy link
Member Author

Recommend added example linker file or add some docs to the readme on how to setup the linker file.

It turns out that the linkage is unnecessary and actually caused some issues, so I am disabling the linkage section header for .flashprog by default.

@WhiteHoodHacker
Copy link
Member Author

Also I see that you are trying to use the embedded ecosystem so you might want to take a look at https://github.com/rust-embedded-community/embedded-storage

I likely won't end up implementing this just because of the nuances of flash management on the MAX78000 (1 -> 0 only bit transformations and large page sizes). Implementing an abstraction that automatically erases an entire page (8192 bytes) would require copying all the previous bytes, modifying them, then writing them back in - this is super expensive.

Users planning to use the flash should be aware of the nuances with the flash controller and use the HAL APIs with care and thought.

@WhiteHoodHacker WhiteHoodHacker marked this pull request as ready for review January 29, 2025 07:26
@WhiteHoodHacker WhiteHoodHacker merged commit cf640d2 into main Jan 29, 2025
@WhiteHoodHacker WhiteHoodHacker deleted the feat/flc branch January 29, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement FLC
2 participants