Implement builder ssz flow #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
commented
Jan 24, 2025
Comment on lines
-68
to
-79
| let fork_name = match &payload { | ||
| FullPayloadContents::Payload(payload) => payload.fork_name(), | ||
| FullPayloadContents::PayloadAndBlobs(payload_and_blobs) => { | ||
| payload_and_blobs.execution_payload.fork_name() | ||
| } | ||
| }; | ||
| ForkVersionedResponse { | ||
| version: Some(fork_name), | ||
| metadata: EmptyMetadata {}, | ||
| data: payload, | ||
| } | ||
| }); |
There was a problem hiding this comment.
@pawanjay176 I've removed this and am instead figuring out the fork name based on block.slot(). I think that should be ok?
pawanjay176
reviewed
Feb 11, 2025
| metadata: EmptyMetadata {}, | ||
| data: body, | ||
| }; | ||
| tokio::task::spawn_blocking(move || { |
There was a problem hiding this comment.
Why are we spawning a new task to just convert to bytes?!
There was a problem hiding this comment.
I'm not sure why were spawning a new task, we were doing it in the JSON case in the existing build_response function so I just kept it the same here.
pawanjay176
force-pushed
the
builder-ssz-flow
branch
from
733f17c to
deeb9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: ethereum/builder-specs#104
ForkVersionDecodein LH. It was required so I could create the relevant axum extractor.JsonOrSszWithForkextractor which can extract request body data that implsDeserializeOwned+ForkVersionDecode.build_response_with_headersForkVersionedResponse& serializes to JSON