fix: advance RLP decoding buffer #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
advance-decode-buffer
branch
from
c77dc46 to
3521aa4
Compare
AgeManning
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Thanks! This looks like a good improvement to me!
@armaganyildirak - As the author of the alloy-rlp upgrade can you also double check this and also re-run the fuzzers on this PR.
Lets merge it once confirmed :).
|
@AgeManning - I checked this PR then I checked the fuzzers and re-run them. Everything is working good. |
AgeManning
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69