Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SSV Handshake Protocol #125
base: unstable
Are you sure you want to change the base?
Implement SSV Handshake Protocol #125
Changes from all commits
e5a10ad
1b36113
8dfba38
fec6579
2f898bc
335de8c
537a988
5162ae6
60c1c13
98b97bc
1d41a3e
b2bd4bf
573dd54
0114cdc
e65e5b4
5d2f6df
97f6534
f755ea5
8f2e545
d0ab738
88e8a92
0c42c26
c096635
71f0de5
7f47b7d
6411d4c
288e0a2
4be67aa
cb9363c
399499c
3ac485b
2a47eb0
a2611e1
b53d49e
aab349e
cc5d0e3
c26750e
c75a225
d9791ce
40dc739
ca67c05
d38776d
db25bae
5fd4866
026d99f
c4ed901
cb4b102
195e742
2954f08
4e12f5e
04cc5bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use workspace dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not defined in the root. Should it be defined there and inherited even if it's used only here for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, good question. We should align with the others on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rule of thumb I use: if it's only used by a subcrate import it there, when it becomes used by two or more, move it to workspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been taking the approach to keep it local if its unlikely to be used in other crates.
If its a general crate, its generally best to put in the workspace dependencies, in case for some reason some other crate decides to use it.
For this specific one, it seems fairly general and conceivable that another crate MIGHT use it in the future, so might be worth chucking in workspace deps.