Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PublicKeyBytes instead of PublicKey #118

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

dknopik
Copy link
Member

@dknopik dknopik commented Jan 28, 2025

PublicKey is the decompressed version of PublicKeyBytes, which is larger in memory and kind of costly to convert. We only need the decompressed version while verifying the signature during sync, so this PR switches to PublicKeyBytes everywhere else.

@dknopik dknopik added ready-for-review This PR is ready to be reviewed database labels Jan 28, 2025
@Zacholme7
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database ready-for-review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants