Replacements no context extraction hotfix & tests (#143)

signavio · Sep 15, 2022 · 6991660 · 6991660
1 parent 2d60cd6
commit 6991660
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/scripts/babel-gettext-extractor/index.js b/src/scripts/babel-gettext-extractor/index.js
@@ -226,7 +226,7 @@ export default function plugin() {
         context[translate.msgid] = translate
 
         if (replacements) {
-          const contextName = translate.msgctxt
+          const contextName = translate.msgctxt || ""
           const contextReplacements = replacements[contextName]
           if (
             contextReplacements &&

diff --git a/test/specs/scripts/extract.spec.js b/test/specs/scripts/extract.spec.js
@@ -59,8 +59,20 @@ describe('extract', () => {
 
       const messages = readFileSync(`${replacementsDir}/messages.pot`).toString("utf-8")
 
-      expect(messages).toContain('msgid "Needs replacement"')
-      expect(messages).toContain(`msgid "A replacement for 'Needs replacement'`)
+
+      expect(messages).toContain([
+        `#: fixtures/replacements/index.js:1`,
+        `msgid "Needs replacement"`,
+        `msgstr ""`,
+      ].join('\n'))
+
+      expect(messages).toContain([
+        `#: fixtures/replacements/index.js:1`,
+        `#. REPLACEMENT for "Needs replacement"`,
+        `msgid "A replacement for 'Needs replacement'"`,
+        `msgstr ""`,
+      ].join('\n'))
+
       expect(messages).toContain('#. REPLACEMENT for "Needs replacement"')
       expect(messages).toContain('msgid "No replacement is needed"')