[mod_pgsql] err is now set correctly (dbh:last_error()) #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1670/index.html |
ar45
force-pushed
the
fix_mod_pgsql_err
branch
from
a27ddb1 to
165055d
Compare
|
@andywolk I rebased this. Can you please have this reviewed? |
andywolk
requested changes
Jan 14, 2025
ar45
force-pushed
the
fix_mod_pgsql_err
branch
from
7a19882 to
44e2b12
Compare
andywolk
changed the title
andywolk
force-pushed
the
fix_mod_pgsql_err
branch
from
44e2b12 to
cef3b4f
Compare
New function, `void pgsql_handle_set_error_if_not_set(switch_pgsql_handle_t *handle, char **err)` has been added to mod_pgsql module. This function is now called at several points where an error occurred but *err was not yet set.
Ensure consistent formatting by adding missing newlines before `return` statements in error handling blocks. This improves code readability and maintains uniformity throughout the module.
andywolk
force-pushed
the
fix_mod_pgsql_err
branch
from
cef3b4f to
91e6632
Compare
andywolk
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function,
void pgsql_handle_set_error_if_not_set(switch_pgsql_handle_t *handle, char **err)has been added to mod_pgsql module. This function is now called at several points where an error occurred but *err was not yet set.