-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes translations for screen readers #5780
fix: fixes translations for screen readers #5780
Conversation
Hi! Can I get some eyes in this very small PR (16 lines, translations only), please? This is impeding some visually impaired friends to properly use the app, effectively prohibiting them the access to a more secure and democratic way to communicate. cc @marissa-signal @pete-signal @elaine-signal @sashaweiss-signal as I saw you submitted commits updating translations since my PR was opened. Thank you very much, and I'm sorry if I disturbed you somehow. |
Hello, any updates on this? It's a very small PR of 16 lines, and it has been 2 months now... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Can someone from the team please take a look at this... 😞 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still waiting for someone to take a look at this |
Please resolve conflicts with base branch. |
1529d2c
to
fd11802
Compare
Give me some minutes to properly check this, translation changed a lot in all those months. I'll inform when ready |
f503d1e
to
f3a6543
Compare
f3a6543
to
64c1fa8
Compare
This PR is more than 9 months old, and it seems all translations I fixed were also fixed by @harry-signal 5 months ago in e09a646. So, when rebasing Nothing to do here it seems |
First time contributor checklist
Contributor checklist
Description
Spanish (ES) translations includes some terms like "amigxs" among others, that following with this example, "amigxs" is
a gender-inclusive way to write "amigos" ("friends" in Spanish).
This happens because in Spanish, and in opposition to English, most nouns have gender, so certain words can be written in masculine (usually ending in a letter "o") or feminine (usually ending in a letter "a"). Therefore, some Spanish-spoken people that doesn't identify themselves in the binary (masculine or feminine) gender started to replace those "o" and "a" letters with an "x" on wrote text, in an attempt to make them more inclusive to anyone.
However, although there are good intentions in this practice, it ends being less inclusive. The main problem is that those "x" substitutions of "o" and "a" are impossible to pronounce in Spanish, as they are substituting a vowel by a consonant. Therefore, screen readers are unable to read those texts, and makes visual-impaired people harder to use the app without help.
iOS is an ecosystem that always has focused on accessibility, and Signal is an app that is intended to be easy and accessible to all kind of people, so I think this is a good change for the community. Specially, because we'll allow those visual-impaired people that currently are unable to use the app to start having a more secure and privately way to communicate with peers :)
So my change is as follows: I changed all those "x" ending words to their "o" version, that is the masculine one, but also, the common noun gender to use in Spanish when you don't know / cannot know the gender of the person to who is referring or affecting that noun. Also, it's the only grammatically/semantically accepted (correct) way to write/speak Spanish according to the institution that rules and documents the usage and evolution of the Spanish Language in Spain, which is Real Academia Española (aka. RAE).