Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info on CMP feature coverage and libcmp hints to README.md; various test etc. fixes #71

Merged
merged 17 commits into from
Dec 16, 2024

Conversation

DDvO
Copy link
Member

@DDvO DDvO commented Nov 29, 2024

No description provided.

@DDvO DDvO added the documentation Improvements or additions to documentation label Nov 29, 2024
@DDvO DDvO requested a review from rajeev-0 November 29, 2024 16:52
@DDvO DDvO changed the title README.md: add info on CMP feature coverage and libcmp hints; few fixes add info on CMP feature coverage and libcmp hints to README.md; various test etc. fixes Dec 14, 2024
@DDvO DDvO force-pushed the README_fixes+CMP-features branch 5 times, most recently from 2bdf06b to a15241d Compare December 14, 2024 19:55
Copy link
Collaborator

@rajeev-0 rajeev-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. just 2 small comment.

doc/cmpClient.pod Show resolved Hide resolved
include/genericCMPClient.h Outdated Show resolved Hide resolved
@DDvO DDvO force-pushed the README_fixes+CMP-features branch from df9f724 to 4a45573 Compare December 16, 2024 10:17
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@rajeev-0 rajeev-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DDvO DDvO merged commit 737e430 into master Dec 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants