Fix bug where commands containing transition field and a status/brigh…

…tness field would generate conflicting transitions
sidoh · Aug 6, 2019 · b90c669 · b90c669
1 parent e86658c
commit b90c669
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/MiLight/MiLightClient.cpp b/lib/MiLight/MiLightClient.cpp
@@ -318,7 +318,13 @@ void MiLightClient::update(JsonObject request) {
 
   // Always turn on first
   if (parsedStatus == ON) {
-    if (transition == 0) {
+    if (
+         transition == 0
+      // Do not generate a transition if a brightness field is also set, since that will also
+      // generate a transition.
+      || request.containsKey(GroupStateFieldNames::BRIGHTNESS)
+      || request.containsKey(GroupStateFieldNames::LEVEL)
+    ) {
       this->updateStatus(ON);
     } else {
       handleTransition(GroupStateField::STATUS, status, transition);