add azure-cli deployment image #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BracketJohn
reviewed
Jul 27, 2022
| @@ -0,0 +1,16 @@ | |||
| FROM segment/chamber:2.10.6 AS chamber | |||
| # FROM mcr.microsoft.com/azure-cli:2.9.1 AS azure-cli | |||
There was a problem hiding this comment.
I think this can go / needs to come back?
There was a problem hiding this comment.
Yes this was just for testing purposes which didnt work out in the end.
| make=4.3-r0 | ||
| RUN pip install --no-cache-dir pip==22.2 | ||
| RUN pip install --no-cache-dir azure-cli==2.38.0 | ||
| RUN apk del --purge build |
There was a problem hiding this comment.
how about an entrypoint cmd command or similar?
There was a problem hiding this comment.
as we have 3 used cli's in this image i just went with a simple /bin/sh as a CMD for atleast a working docker run if needed.
BracketJohn
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #https://github.com/sidestream-tech/textiltiger/pull/174
Dockerfiles which provides the azure-cli needed for the textiltiger production deployment to an azure kubernetes cluster.
Tried to make it as small as possible but for some reason is the
azure-clifor alpine riughly still 1 GB big, this Issue Azure/azure-cli#19591 is still open so they are working on making it smaller.Checklist:
#)