Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catching parsing errors for midi_cc_file.json #366

Merged
merged 1 commit into from
Sep 9, 2024
Merged

catching parsing errors for midi_cc_file.json #366

merged 1 commit into from
Sep 9, 2024

Conversation

bwhitman
Copy link
Collaborator

@bwhitman bwhitman commented Sep 8, 2024

No description provided.

@bwhitman
Copy link
Collaborator Author

bwhitman commented Sep 8, 2024

@dpwe can you take a look

@dpwe
Copy link
Collaborator

dpwe commented Sep 9, 2024

Looks good to me. Those arp key bindings are very specific to my setup, we def don't want to depend on them.

@dpwe dpwe merged commit 36a469a into main Sep 9, 2024
1 check passed
@dpwe
Copy link
Collaborator

dpwe commented Sep 9, 2024

I guess there's a similar problem in juno6.py - it will hit index errors with shorter midi control lists. But at least that doesn't run at startup.

bwhitman added a commit that referenced this pull request Sep 9, 2024
bwhitman added a commit that referenced this pull request Sep 9, 2024
fix for similar thing as #366 for juno6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants