fix(vue-demo): double opt in registration #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@shopware/api-client
@shopware/api-gen
@shopware-pwa/cms-base
@shopware-pwa/composables-next
@shopware-pwa/helpers-next
@shopware-pwa/nuxt3-module
commit: |
patzick
reviewed
Nov 27, 2024
templates/vue-demo-store/components/account/AccountRegisterForm.vue
Outdated
Show resolved
Hide resolved
patzick
reviewed
Nov 27, 2024
templates/vue-demo-store/components/account/AccountRegisterForm.vue
Outdated
Show resolved
Hide resolved
patzick
requested changes
Nov 28, 2024
BrocksiNet
approved these changes
Dec 4, 2024
vercel
bot
temporarily deployed
to
Preview – shopware-frontends-docs
patzick
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Looks good, let's link the issue @BrocksiNet mentioned and we can merge it!
|
@BrocksiNet you mean the link in the email? This is a storefront domain configuration, we cannot change it on the cloud because of the domain verification |
|
@kstala can you check e2e here? |
|
@patzick double-opt-in was enabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to improve user registration and session handling.
Improvements to user registration and session handling:
packages/composables/src/useUser/useUser.ts: Updated theuseUserfunction to set user data when the user is active and not in double opt-in registration, and to refresh the session context accordingly.templates/vue-demo-store/components/account/AccountRegisterForm.vue: Modified theinvokeSubmitfunction to handle double opt-in registration flow correctly and navigate active users to the home page.Added a confirmation page after the double opt-in option. The confirmation link is included in the email after registration.
closes #1462
Type of change
ToDo's
Screenshots (if applicable)
Additional context