Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update add-custom-controller.md #1305

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Update add-custom-controller.md #1305

merged 1 commit into from
Feb 29, 2024

Conversation

thijsMemoICT
Copy link
Contributor

Changed type for routes.xml as mentioned in shopware/shopware#3566

@thijsMemoICT
Update add-custom-controller.md
1919f5e 
Changed type for routes.xml as mentioned in shopware/shopware#3566
@Isengo1989
Copy link
Collaborator

We should also double-check the other mentions, for example:

Furthermore, we have to define our Route with defaults and _routeScope via annotation, it is used to define which domain a route is part of and needs to be set for every route. In our case the scope is storefront.

Should be renamed to via attribute

@tobiasberge tobiasberge requested a review from ssltg February 29, 2024 09:42
@Isengo1989 Isengo1989 merged commit 162fd15 into shopware:next-6.6 Feb 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssltg ssltg ssltg approved these changes

@tobiasberge tobiasberge Awaiting requested review from tobiasberge

@Isengo1989 Isengo1989 Awaiting requested review from Isengo1989

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thijsMemoICT @Isengo1989 @ssltg