Skip to content

Commit

Permalink
🪟 🎨 Add description to dbt cloud service token form (airbytehq#22702)
Browse files Browse the repository at this point in the history
  • Loading branch information
josephkmh authored Feb 14, 2023
1 parent 3b31548 commit cee17bd
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 3 deletions.
1 change: 1 addition & 0 deletions airbyte-webapp/src/packages/cloud/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
"settings.integrationSettings": "Integration settings",
"settings.integrationSettings.dbtCloudSettings": "dbt Cloud Integration",
"settings.integrationSettings.dbtCloudSettings.form.serviceToken": "Service Token",
"settings.integrationSettings.dbtCloudSettings.form.description": "To use the dbt Cloud integration, enter your service token here. <lnk>Learn more</lnk>.",
"settings.integrationSettings.dbtCloudSettings.form.advancedOptions": "Advanced options",
"settings.integrationSettings.dbtCloudSettings.form.singleTenantUrl": "Single-tenant URL",
"settings.integrationSettings.dbtCloudSettings.form.testConnection": "Test connection",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
@use "scss/colors";
@use "scss/variables";

.controlGroup {
Expand All @@ -9,3 +10,18 @@
margin-left: variables.$spacing-md;
}
}

.cardContent {
padding: variables.$spacing-xl;
}

.description {
color: colors.$grey-300;
margin-bottom: variables.$spacing-xl;
font-size: 12px;

a:link,
a:visited {
color: colors.$grey-300;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ import { FormattedMessage, useIntl } from "react-intl";

import { LabeledInput } from "components/LabeledInput";
import { Button } from "components/ui/Button";
import { Text } from "components/ui/Text";

import { useSubmitDbtCloudIntegrationConfig } from "packages/cloud/services/dbtCloud";
import { Content, SettingsCard } from "pages/SettingsPage/pages/SettingsComponents";
import { SettingsCard } from "pages/SettingsPage/pages/SettingsComponents";
import { links } from "utils/links";

import styles from "./DbtCloudSettingsView.module.scss";

Expand All @@ -17,7 +19,7 @@ export const DbtCloudSettingsView: React.FC = () => {
const [validationMessage, setValidationMessage] = useState("");
return (
<SettingsCard title={<FormattedMessage id="settings.integrationSettings.dbtCloudSettings" />}>
<Content>
<div className={styles.cardContent}>
<Formik
initialValues={{
serviceToken: "",
Expand All @@ -41,6 +43,18 @@ export const DbtCloudSettingsView: React.FC = () => {
}}
>
<Form>
<Text className={styles.description}>
<FormattedMessage
id="settings.integrationSettings.dbtCloudSettings.form.description"
values={{
lnk: (node: React.ReactNode) => (
<a href={links.dbtCloudIntegrationDocs} target="_blank" rel="noreferrer">
{node}
</a>
),
}}
/>
</Text>
<Field name="serviceToken">
{({ field }: FieldProps<string>) => (
<LabeledInput
Expand All @@ -59,7 +73,7 @@ export const DbtCloudSettingsView: React.FC = () => {
</div>
</Form>
</Formik>
</Content>
</div>
</SettingsCard>
);
};
1 change: 1 addition & 0 deletions airbyte-webapp/src/utils/links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const BASE_DOCS_LINK = "https://docs.airbyte.com";

export const links = {
dbtCommandsReference: "https://docs.getdbt.com/reference/dbt-commands",
dbtCloudIntegrationDocs: `${BASE_DOCS_LINK}/cloud/dbt-cloud-integration`,
technicalSupport: `${BASE_DOCS_LINK}/troubleshooting/on-deploying`,
termsLink: "https://airbyte.com/terms",
privacyLink: "https://airbyte.com/privacy-policy",
Expand Down

0 comments on commit cee17bd

Please sign in to comment.