Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use v1 Tekton PipelineRun and v1beta1 Build and BuildRun #77

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Use v1 Tekton PipelineRun and v1beta1 Build and BuildRun #77

merged 1 commit into from
Dec 6, 2023

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Fixes #76

This pull request changes the PipelineRun controller to reconcile the v1 version of the Tekton PipelineRun.

This PR also changes the code to use the v1beta1 version of the Build and BuildRun API.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The controllers are now based on the latest versions of the PipelineRun (Tekton v1) and Build/BuildRun (Shipwright v1beta1) APIs

@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 24, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 24, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Nov 27, 2023
Closed
qu1queee
qu1queee approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SaschaSchwarze0,qu1queee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1c7f453 into shipwright-io:main Dec 6, 2023
5 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-api-updates branch December 9, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adopt Tekton V1 PipelineRun API
2 participants
@SaschaSchwarze0 @qu1queee