-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: react renderer #3
Conversation
I have merged the two playgrounds into one. This could help the long-term maintainability as well as easily compare between different renderers. Tho with my limited understanding of React, the approach is quite hacky. And we also run into the problem that react renders twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't fix it - count on someone to help
@antfu This problem should have been fixed. The reason is that React requires that the component function must be "pure", so the component will be mounted twice in the dev environment, resulting in multiple commits, overwriting the previous results, and making us unable to see the animation. So I need to compare whether related properties have changed. Thank you very much for your work merging the playground and refactoring my code. |
I added a React wrapper, most code is just like the Vue version and looks like it works.