Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bluesky support (#2302) #2303

Closed
wants to merge 6 commits into from
Closed

add Bluesky support (#2302) #2303

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a50832
add Bluesky support (#2302)
ibnaleem Sep 25, 2024
cf83a95
Change ProductHunt's error type from message to status_code
ibnaleem Oct 2, 2024
842e829
Change NitroType's errorType from message to status_code
ibnaleem Oct 2, 2024
7d412e0
Change Lichess's errorType from message to status_code
ibnaleem Oct 2, 2024
1601ee9
Update Kick's previous error message to the latest error message
ibnaleem Oct 2, 2024
4ee3016
Change Houzz's errorType from message to status_code
ibnaleem Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions sherlock_project/resources/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,8 +1069,7 @@
"username_claimed": "red"
},
"Houzz": {
"errorMsg": "The page you requested was not found.",
"errorType": "message",
"errorType": "status_code",
"url": "https://houzz.com/user/{}",
"urlMain": "https://houzz.com/",
"username_claimed": "blue"
Expand Down Expand Up @@ -1231,7 +1230,7 @@
},
"Kick": {
"__comment__": "Cloudflare. Only viable when proxied.",
"errorMsg": "Not Found",
"errorMsg": "Oops, something went wrong",
"errorType": "message",
"url": "https://kick.com/{}",
"urlMain": "https://kick.com/",
Expand Down Expand Up @@ -1296,8 +1295,7 @@
"username_claimed": "blue"
},
"Lichess": {
"errorMsg": "Page not found!",
"errorType": "message",
"errorType": "status_code",
"url": "https://lichess.org/@/{}",
"urlMain": "https://lichess.org",
"username_claimed": "blue"
Expand Down Expand Up @@ -1510,8 +1508,7 @@
"username_claimed": "goku"
},
"NitroType": {
"errorMsg": "<title>Nitro Type | Competitive Typing Game | Race Your Friends</title>",
"errorType": "message",
"errorType": "status_code",
"url": "https://www.nitrotype.com/racer/{}",
"urlMain": "https://www.nitrotype.com/",
"username_claimed": "jianclash"
Expand Down Expand Up @@ -1664,8 +1661,7 @@
"username_claimed": "blue"
},
"ProductHunt": {
"errorMsg": "We seem to have lost this page",
"errorType": "message",
"errorType": "status_code",
"url": "https://www.producthunt.com/@{}",
"urlMain": "https://www.producthunt.com/",
"username_claimed": "jenny"
Expand Down Expand Up @@ -2802,5 +2798,12 @@
"url": "https://www.znanylekarz.pl/{}",
"urlMain": "https://znanylekarz.pl",
"username_claimed": "janusz-nowak"
},
"Bluesky": {
"errorMsg": "<title>@{} — Bluesky</title>",
"errorType": "message",
"url": "https://bsky.app/profile/{}.bsky.social",
Comment on lines +2803 to +2805
Copy link

@jasontenpenny jasontenpenny Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is going to work super well. If the user doesn't have a display name, I think the title of the page will match this even if the user exists. It might be better to use the status_code errorType and then specify the actual API call that looks up the user. That should respond with a 400 if the user doesn't exist. The API call would be https://public.api.bsky.app/xrpc/com.atproto.identity.resolveHandle?handle={}.bsky.social

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ibnaleem before I run through things do you have any thoughts here?

"urlMain": "https://bsky.app/",
"username_claimed": "kanaratron"
}
}
Loading