Skip to content

Commit

Permalink
fix: query-range skip tls verify
Browse files Browse the repository at this point in the history
  • Loading branch information
710leo committed Aug 3, 2023
1 parent 15dcc60 commit 6c42ae9
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 5 deletions.
8 changes: 7 additions & 1 deletion prom/option.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
package prom

import "sync"
import (
"sync"

"github.com/ccfos/nightingale/v6/pkg/tlsx"
)

type PromOption struct {
ClusterName string
Expand All @@ -15,6 +19,8 @@ type PromOption struct {
MaxIdleConnsPerHost int

Headers []string

tlsx.ClientConfig
}

func (po *PromOption) Equal(target PromOption) bool {
Expand Down
17 changes: 13 additions & 4 deletions prom/reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ func (pc *PromClientMap) loadFromDatabase() {
Headers: header,
}

if strings.HasPrefix(ds.HTTPJson.Url, "https") {
po.UseTLS = true
po.InsecureSkipVerify = ds.HTTPJson.TLS.SkipTlsVerify
}

if internalAddr != "" && !pc.ctx.IsCenter {
// internal addr is set, use internal addr when edge mode
po.Url = internalAddr
Expand Down Expand Up @@ -130,11 +135,13 @@ func (pc *PromClientMap) loadFromDatabase() {
}

func (pc *PromClientMap) newReaderClientFromPromOption(po PromOption) (api.Client, error) {
tlsConfig, _ := po.TLSConfig()

return api.NewClient(api.Config{
Address: po.Url,
RoundTripper: &http.Transport{
// TLSClientConfig: tlsConfig,
Proxy: http.ProxyFromEnvironment,
TLSClientConfig: tlsConfig,
Proxy: http.ProxyFromEnvironment,
DialContext: (&net.Dialer{
Timeout: time.Duration(po.DialTimeout) * time.Millisecond,
}).DialContext,
Expand All @@ -145,11 +152,13 @@ func (pc *PromClientMap) newReaderClientFromPromOption(po PromOption) (api.Clien
}

func (pc *PromClientMap) newWriterClientFromPromOption(po PromOption) (api.Client, error) {
tlsConfig, _ := po.TLSConfig()

return api.NewClient(api.Config{
Address: po.WriteAddr,
RoundTripper: &http.Transport{
// TLSClientConfig: tlsConfig,
Proxy: http.ProxyFromEnvironment,
TLSClientConfig: tlsConfig,
Proxy: http.ProxyFromEnvironment,
DialContext: (&net.Dialer{
Timeout: time.Duration(po.DialTimeout) * time.Millisecond,
}).DialContext,
Expand Down

0 comments on commit 6c42ae9

Please sign in to comment.