Update workflows to be faster + more recent #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run `bundle lock --add-platform x86_64-linux` (to allow running on linux) see advice from https://github.com/helaili/jekyll-action ...and https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow
LouiseMcMahon
approved these changes
Jul 3, 2024
|
I will merge. let's see how it goes... ;] |
|
mm, yes. it looks like the sources setting must be changed (see above) to allow the workflow to complete failed run: https://github.com/sheffieldhackspace/Public-Website/actions/runs/9801071365/job/27063865356
|
LouiseMcMahon
added a commit
that referenced
this pull request
Jul 5, 2024
This reverts commit 0e4a7b8.
|
Thats fixed now, just manually triggered a build https://github.com/sheffieldhackspace/Public-Website/actions/runs/9805559436 |
|
lovely stuff. thanx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current workflows take far too long to run. The latest is
https://github.com/sheffieldhackspace/Public-Website/actions/runs/8287118405
which took 7 minutes.
The build test also takes several minutes.
Also, the action used (
helaili/jekyll-action) is deprecated.It is recommended to replace this with the GitHub Action for creating a page. See guidance here
The workflows introduced in this PR are much faster, making it much less annoying to develop. They also are in-line with the recommendations. For example, here are some workflows from my fork:
test
https://github.com/alifeee/Public-Website/actions/runs/8660606381
deploy
https://github.com/alifeee/Public-Website/actions/runs/8660613710
This may also require the sources setting to be changed under pages settings. Or it may update automatically.