Modified non_parcel_bunkers_motion_experimental to use non pressure weighted mean wind #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #209, it appears as though non_parcel_bunkers_motion_experimental is the function most similar to the process described in Bunkers et al. 2000 in that it uses the shear vector from the 0-0.5km mean wind to the 5.5-6km mean wind. The issue is that it was using the 0-6km pressure weighted mean wind in the calculation rather than the non pressure weighted mean wind which is recommended in Bunkers et al. 2000 and reaffirmed in Bunkers et al. 2014. This change modifies the function to use the non-pressure weighted mean wind. If the intention was to use pressure weighted mean wind, it should probably be the 0-8km mean wind as this was found to minimize error in Bunkers et al. 2014. This change does not solve the broader problem brought up by #209, namely that the bunkers motion calculations in SHARPpy use the 0-6km shear vector rather than the shear vector from the 0-0.5km mean wind to the 5.5-6km mean wind, but I was reluctant to make any larger changes as I'm not sure if this is actually a bug or if there was a valid reason as to why the 0-6km shear is being used.