Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clircle to 0.6.1 #3113

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

niklasmohrin
Copy link
Contributor

This includes mostly dependency updates. The most significant one is that I removed clircle's dependency on winapi. After this PR, running cargo update on bat will remove winapi from the lockfile.

@niklasmohrin
Copy link
Contributor Author

I re-applied the same changes on the current main branch - the cargo audit failure is unrelated to this change

@keith-hall
Copy link
Collaborator

Unfortunately it looks like we will need to address the audit failure before we can merge this PR

@keith-hall
Copy link
Collaborator

Audit failures have been fixed in #3154

@niklasmohrin
Copy link
Contributor Author

Cool, I updated the PR :)

Should we cargo update here, or do you want to do it at a later point?

@keith-hall keith-hall enabled auto-merge January 3, 2025 06:57
@keith-hall
Copy link
Collaborator

Cool, I updated the PR :)

Should we cargo update here, or do you want to do it at a later point?

We can do it separately :) ideally we will make a new release soon, so I guess it makes sense to update dependencies first

auto-merge was automatically disabled January 5, 2025 15:37

Head branch was pushed to by a user without write access

This release removes the dependency on `winapi`.
@niklasmohrin
Copy link
Contributor Author

niklasmohrin commented Jan 5, 2025

@keith-hall It looks like #3161 bumped the version in the meantime, I suppose we can still remove the default features and note the update reason - or not, if you want :)

(the previously accepted change did not pass CI: https://github.com/sharkdp/bat/actions/runs/12594019120/job/35100879456)

@keith-hall keith-hall merged commit 18ed69a into sharkdp:master Jan 5, 2025
24 checks passed
@keith-hall
Copy link
Collaborator

Thanks 👍

@niklasmohrin niklasmohrin deleted the bump-clircle branch January 5, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants