Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add post-config script #106

Closed
wants to merge 1 commit into from
Closed

add post-config script #106

wants to merge 1 commit into from

Conversation

zshannon
Copy link

Adding support for a post-config script that runs during GH runner setup.

Motivation and Context

I need to modify the github runner's binary to modify its actions/cache behavior like this and figured a post-config script could be generally useful.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@zshannon zshannon requested a review from simonbs as a code owner January 24, 2025 04:01
@zshannon
Copy link
Author

I ended up needing to hardcode the ACTIONS_CACHE_URL value in a custom build of the actions runner so perhaps this PR isn't helpful, feel free to close.

If you wanna explore building caching in here, happy to share my experience eventually getting it to work.

@simonbs
Copy link
Contributor

simonbs commented Jan 27, 2025

@zshannon Thanks for opening the PR! I understand that you needed to hardcode ACTIONS_CACHE_URL but did you also end up relying on the post-config script or are you no longer using it?

@zshannon
Copy link
Author

zshannon commented Jan 27, 2025

I ended up using the cirruslabs/cache action which redefines ACTION_CACHE_URL at cache execution time (but with my own CIRRUS_HTTP_CACHE_HOST value pointing at an instance of gha-cache-server on my network)

@simonbs
Copy link
Contributor

simonbs commented Jan 27, 2025

Alright. I think the changes in this PR are a great fit for Tartelet but I’d prefer not introducing it until anyone’s actually using it, so we don’t have to test and maintain unused features.

Therefore, I’ll close the PR but certainly do feel free to reopen it if you ever need this in Tartelet 😊

@simonbs simonbs closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants