Use HTTPS in link to Wikipedia article on password strength #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes themselves look good, but the commit message does not follow the project practices. We usually limit the commit title to 50 characters and the message lines to 72. In addition, we mention the folder in which we are committing the changes in the title and add the links at the end. Here is an example to show you what is expected: 0b8c0c8 |
scottdotweb
force-pushed
the
scottdotweb-patch-1
branch
2 times, most recently
from
e398000 to
674cf1d
Compare
The link to Wikipedia's article "Password strength" was added here in 2008 and Wikipedia went HTTPS-only 7 years later. Link: <https://diff.wikimedia.org/2015/06/12/securing-wikimedia-sites-with-https/>
scottdotweb
force-pushed
the
scottdotweb-patch-1
branch
from
674cf1d to
d6a74b2
Compare
|
Hi Iker and thanks for the guidance 🙂 This project is quite outside my usual area of contributions. I've modified the commit per those rules. |
alejandro-colomar
approved these changes
Jan 7, 2025
ikerexxe
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to the Wikipedia article was added here in 2008, and Wikipedia went HTTPS-only in 2015. (https://diff.wikimedia.org/2015/06/12/securing-wikimedia-sites-with-https/)